feat: Pivot filter UI #1278
Open
feat: Pivot filter UI #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
…lugins into pivot-plugin
…column-and-filters
mofojed
requested changes
Jan 19, 2026
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Just a minor question/nitpick. looks good overall.
Comment on lines
+6
to
+7
| * Hook that creates a pivot metric calculator | ||
| * @returns Pivot metric calculator |
Member
There was a problem hiding this comment.
I'd say this returns a factory for creating a pivot metric calculator, since it's returning a function that creates the pivot metric calculator, not the pivot metric calculator itself.
| * @returns Pivot metric calculator | ||
| */ | ||
| export function usePivotMetricCalculator(): GetMetricCalculatorType { | ||
| return useMemo(() => args => new IrisGridPivotMetricCalculator(args), []); |
Member
There was a problem hiding this comment.
Use ... in case more parameters are added? Though I guess most likely we'll just keep one arg anyway and then keep adding to that...
Suggested change
| return useMemo(() => args => new IrisGridPivotMetricCalculator(args), []); | |
| return useMemo(() => (...args) => new IrisGridPivotMetricCalculator(...args), []); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add filter support for pivot table ColumnBy sources.
IrisGridPivotRendererandIrisGridPivotMetricCalculatorto render filter input boxes in the column header groups. Filter boxes take all available space to the left of the ColumnBy labels.IrisGridPivotModelto expose and apply filters on the underlying pivot table.